microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
45 stars 25 forks source link

Deprecate functions *_join #515

Closed thpralas closed 2 months ago

thpralas commented 2 months ago

This PR deprecates following functions :

These functions were aliases for mergeSEs with parameter join, thus they do not need to be replaced.

antagomir commented 2 months ago

Could you check that we have at least one example in OMA Ch. 3 about using the SEtools if these are removed from here?

TuomasBorman commented 2 months ago

We still have mergeSEs function. The intention was to remove these aliases; they make things more complicated without adding value

antagomir commented 2 months ago

right - and in fact we already have examples in oma as well so I guess it is Ok

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (devel@c96a4e5). Click here to learn what that means.

Files Patch % Lines
R/deprecate.R 0.00% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #515 +/- ## ======================================== Coverage ? 72.20% ======================================== Files ? 40 Lines ? 4677 Branches ? 0 ======================================== Hits ? 3377 Misses ? 1300 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.