WIP: Import taxpasta - Githubissues

microbiome / mia

Microbiome analysis

https://microbiome.github.io/mia/

Artistic License 2.0

45 stars 25 forks source link

WIP: Import taxpasta #574

Open Midnighter opened 3 weeks ago

Midnighter commented 3 weeks ago

To do:

[ ] expand documentation
[ ] I need to import some biomformat internals, which I can only do with biomformat:::. I see no way around this at the moment.

Midnighter commented 2 weeks ago

Thank you for the detailed review @TuomasBorman! I have some open questions from your comments and will appreciate your assistance with the documentation. It's not clear to me why to break up the docstring like that for a single function and how to direct importTaxpasta's docstring to the general file.

Midnighter commented 1 week ago

Hi @TuomasBorman,

Starting next week, I will have more time again and could try to complete this PR. I would need some advice and decisions from your side, though, please. If you can take another look, I will be grateful.

TuomasBorman commented 1 week ago

Hi @TuomasBorman,

Starting next week, I will have more time again and could try to complete this PR. I would need some advice and decisions from your side, though, please. If you can take another look, I will be grateful.

Alright, sounds good. I have also been busy, but I will check during this week.

Midnighter commented 8 hours ago

@TuomasBorman, I believe, I have addressed all of your comments. Please have another look and let me know if there's something else to be addressed.