microbiome / miaViz

Microbiome Analysis Plotting and Visualization
https://microbiome.github.io/miaViz
Artistic License 2.0
10 stars 11 forks source link

Replace getPrevalence with addPrevalence #119

Closed thpralas closed 3 months ago

thpralas commented 5 months ago

After mia PR https://github.com/microbiome/mia/pull/529 that renamed the following functions :

This PR replaces getPrevalence with addPrevalence in miaViz.

antagomir commented 4 months ago

imo OK to merge

antagomir commented 4 months ago

@thpralas still some failing checks?

TuomasBorman commented 4 months ago

Bioconductor devel does not still have latest changes. That is because there is a pending agglomerateByRank issue. The fixes are already merged in devel, so we have to solve the issue before pushing to Bioconductor

thpralas commented 3 months ago

The R CMD check warning should be solved when pushing mia current version to Bioc devel.

thpralas commented 3 months ago

This PR is linked to mia PR https://github.com/microbiome/mia/pull/529 that was closed.