search

microbiome / miaViz

Microbiome Analysis Plotting and Visualization
https://microbiome.github.io/miaViz
Artistic License 2.0
10 stars 12 forks source link

Accessible color palette #157

Open TuomasBorman opened 1 month ago

TuomasBorman commented 1 month ago

Switch to accessible color palette. Related issue in OMA: https://github.com/microbiome/OMA/issues/197

Daenarys8 commented 1 month ago

I am looking at this. Should pass a param for this palette, there are several options to configure plots. Also microshades is not yet on bioc, I am not sure how this wil affect the bioc checks if we make it a dependency.

TuomasBorman commented 1 month ago

I think we could just switch using the new palette without new parameter (because colorblind-friendliness is the good practice that we want to enhance). That might be the most simplest option (optimally we could have global variable that controls the color palette). The palette can be switched to any other palette outside the function. But let's first discuss what the palette would be.

I have used Rcolorbrewer but there might be others https://www.datanovia.com/en/blog/the-a-z-of-rcolorbrewer-palette/

antagomir commented 1 month ago

I have mentioned this now in microshades issue.

microViz also relevant.

Meanwhile, I do not mind too much as the palette seems nice. Any suggestions?

TuomasBorman commented 1 month ago

One thing that came to mind is to check what color palette scater is using. We could use the same, if it is good.

The color palette package should come from CRAN or Bioc

antagomir commented 1 week ago

This also MetBrewer