search

microbiome / miaViz

Microbiome Analysis Plotting and Visualization
https://microbiome.github.io/miaViz
Artistic License 2.0
10 stars 12 forks source link

Build fix #75

Closed TuomasBorman closed 1 year ago

TuomasBorman commented 1 year ago

miaTime cannot even be in "suggests" as it causes an error in build https://master.bioconductor.org/checkResults/3.17/bioc-LATEST/miaViz/nebbiolo1-checksrc.html

antagomir commented 1 year ago

miaTime cannot even be in "suggests" as it causes an error in build https://master.bioconductor.org/checkResults/3.17/bioc-LATEST/miaViz/nebbiolo1-checksrc.html

Right: we should just finalize that package, and submit to Bioc, when time will allow..

.. and meanwhile indeed just remove from Suggests.. perhaps examples can be moved to miaTime package if useful.

TuomasBorman commented 1 year ago

Yes, sure

I just disabled miaTime examples and test using data from it because it seems to cause an error

miaTime is using package SEtools which is using biocGenerics::rowSums --> rowSums has moved to MatrixGenerics https://github.com/Bioconductor/BiocGenerics/commit/5d95680bc8cafd0833ee96415b07f6ad18d53b99

antagomir commented 1 year ago

Ok good to open issues in miaTime but seems you just opened some already.