search

microbiome / miaViz

Microbiome Analysis Plotting and Visualization
https://microbiome.github.io/miaViz
Artistic License 2.0
9 stars 10 forks source link

Default ranks #88

Open antagomir opened 10 months ago

antagomir commented 10 months ago

In plotAbundance() the default rank is set to rank = taxonomyRanks(x)[1].

This can be confusing since the data is aggregated to higher than original level without user intervention.

Perhaps better to have no rank specified by default (using the highest resolution data available): rank=NULL?

himmil commented 10 months ago

If the default for rank is set to NULL, then plotAbundance() has an identical default function to plotExpression() from scater. Is it a problem?

antagomir commented 10 months ago

I dont think it is a problem. It is nevertheless a different function, with some microbiome-specific extensions (I think). The defaults can be the same and that might even be beneficial, for comparison.

antagomir commented 3 months ago

@himmil could you check this with Noah for a practice.