microbiomedata / metaMAGs

Workflow for metagenome assembled genomes generation.
5 stars 4 forks source link

remove JGI mbin files from Docker folder #25

Closed aclum closed 5 months ago

aclum commented 5 months ago

We do not have permission to distribute these files, they were added with commit id 14ec4dafe468223854332a8664364f88d852cdcb in June 2023. I have removed them in the master branch. We either need to update the mbin_nmdc task in the wdl such that it only requires Neha's container, njvarghese/mbin:v0.4, or we need to work with Neha to include mbin_stats.py, which I believe is NMDC code, in a new version of the container.

aclum commented 5 months ago

We are expecting an updated container from Neha that has the eukcc component shortly so we may want to combine these updates.

ssarrafan commented 5 months ago

Appears to be active. Will move to next sprint for completion. FYI @chienchi @aclum

aclum commented 5 months ago

This is the container we should use library.jgi.doe.gov:5050/metagenome-science-program/mbin-docker:v1.0

Neha is making her dockerhub private shortly so we shouldn't use containers from dockerhub's njvarghese namespace.