search

microbiomedata / metaMS

GC-MS Based Metabolomics Workflow
BSD 2-Clause "Simplified" License
4 stars 0 forks source link

Remove `to_json` method from `LCMSParameters` in `encapsulation/factory/parameters` module to `encapsulation/output/parameter_to_json` and adjust usage throughout. #50

Closed kheal closed 2 months ago

kheal commented 2 months ago

In response to Yuri's comment on the gitlab MR 78

kheal commented 2 months ago

Complete on lcmsrefactor branch, in review to lcms_dev branch. Review and merge into lcms_dev is tracked on #38.

See https://code.emsl.pnl.gov/mass-spectrometry/corems/-/commit/7a344c0309b4cceb0bee8c82e726d5af115bb389 and updated MR https://code.emsl.pnl.gov/mass-spectrometry/corems/-/merge_requests/78