search

microbiomedata / metadata-for-user-facility-template-transformations

CLI tool to convert metadata submissions from the NMDC submission portal to user facility Excel templates
0 stars 0 forks source link

analysis type is formatted incorrectly #21

Open mslarae13 opened 1 year ago

mslarae13 commented 1 year ago

for analysis_type in the EMSL template the variables should be listed as text. Need to remove the [] and ' ' around each term.

They should also be separated by a ; not a ,

However, I think there's further discussion to have about if this should be | for both NMDC and EMSL

sujaypatil96 commented 2 months ago

Fixed in https://github.com/microbiomedata/metadata-for-user-facility-template-transformations/commit/90dd5b5db7a9093fd9f82c4de684da7387727870. List type cells are separated by ; for no. This issue can be closed.

mslarae13 commented 2 months ago

@sujaypatil96 I tested using 7f29bd0b-4616-40d3-aac7-24e450f9f5dc & the metadata didn't export

Can you test this out and let me know if it's working for you?

ssarrafan commented 2 months ago

Checked with @mslarae13 and she said she will test but that this should go in the backlog for now. Natalie may be helping with this in a future sprint. FYI @sujaypatil96