microbiomedata / mg_annotation

Metagenome Annotation Workflow
4 stars 7 forks source link

add support for Contig Mapping File #24

Closed aclum closed 3 months ago

aclum commented 9 months ago

There are a few things we need to confirm are working properly so we can support NMDC workflows that start with an input assembly file. That is, workflows that start with a contigs file, instead of reads. In this case we need to

see related task on the automation side https://github.com/microbiomedata/nmdc_automation/issues/35

cc @mhuntemann @scanon

aclum commented 6 months ago

@hubin-keio is there someone else on the LANL side that can work on this?

aclum commented 6 months ago

If you need to look at the original code that our pre_qc task comes from it is here https://code.jgi.doe.gov/img/img-pipelines/img-annotation-pipeline/-/tree/main/bin/qc/pre-annotation?ref_type=heads

aclum commented 6 months ago

This is required for rerunning annotation post re-iding (if assemblies came from JGI), 16 JGI 1000 soil projects and 87 JGI NEON projects.

ssarrafan commented 5 months ago

@mbthornton-lbl will be continuing to work on this in the next sprint per Slack message. Moving over.

kaijli commented 5 months ago

Currently testing addition of map file task to master branch of mg_annotation (new branch called mapping). Tried adding it to wdl v 1.0 branch but ran into gm_license issues (branched called map_file).

kaijli commented 5 months ago

Branch is ready for merge, pull request created, test results sent to @aclum

aclum commented 4 months ago

@kaijli is there an update here? Based on the last discussion the annotation identifiers should be used.

aclum commented 4 months ago

Per @kaijli in testing.

ssarrafan commented 4 months ago

Moving to next sprint to complete testing

kaijli commented 3 months ago

https://github.com/microbiomedata/mg_annotation/pull/28 merged with master branch