search

microbiomedata / nmdc-edge

Web-based interface to the NMDC EDGE platform
https://nmdc-edge.org
3 stars 0 forks source link

Bug: Config value contains typo and is invalid #102

Closed eecavanna closed 5 months ago

eecavanna commented 5 months ago

Commit https://github.com/microbiomedata/nmdc-edge/commit/10f3e79b328e9368d707cc4555cb4f003a15a0bd introduced a bug:

https://github.com/microbiomedata/nmdc-edge/blob/10f3e79b328e9368d707cc4555cb4f003a15a0bd/webapp/client/src/config.js#L102

The expression after the || is now "makeLocalUri(" / ")".

I recommend removing the surrounding double quotes:

- process.env.REACT_APP_API_URL || "makeLocalUri("/")",
+ process.env.REACT_APP_API_URL || makeLocalUri("/"),
yxu-lanl commented 5 months ago

When I made the change, I didn't notice that VS Code added the double quotes.

yxu-lanl commented 5 months ago

Fixed. Thanks.