search

microbiomedata / nmdc-edge

Web-based interface to the NMDC EDGE platform
https://nmdc-edge.org
3 stars 0 forks source link

ORCID login no longer works (Jetstream2) #222

Closed eecavanna closed 2 days ago

eecavanna commented 3 days ago

Here's a screenshot showing the symptom:

image

eecavanna commented 3 days ago

It may be the case that the REACT_APP_ORCID_CLIENT_ID environment variable is not defined in the environment where the web client (currently part of the web app container) is being built. In this case, that environment is a GitHub Actions runner.

eecavanna commented 3 days ago

Steps to resolve this

  1. Create a repository variable named ORCID_CLIENT_ID whose value is APP-CTM81LRCLW9QLGB9. Note: This is not "sensitive" information. For example, it is in the URL that the ORCID Login button on the production website points to.
  2. Update the GitHub Actions workflow to access that variable via ${{ vars.ORCID_CLIENT_ID }} and make it available to the docker/build-push-action@v5 step via: 
                  build-args: |
                NMDC_EDGE_WEB_APP_VERSION=${{ github.ref_name }}
+                REACT_APP_ORCID_CLIENT_ID=${{ vars.ORCID_CLIENT_ID }}
eecavanna commented 3 days ago

@mflynn-lanl, will you do step 1 above (i.e. create that repository variable)? I don't have that level of permissions in this repository (I cannot access the "Settings" tab).