microbiomedata / nmdc-field-notes

Mobile app for metadata collection on the go
https://fieldnotes.microbiomedata.org/
Other
1 stars 0 forks source link

Unable to save changes of sample metadata when save button out of frame #84

Closed simroux closed 5 months ago

simroux commented 6 months ago

Note: this is for after GSP/ ECR :-)

Just something I noticed on my phone, but I can replicate if I reduce the window size on my browser:

Possible solutions:

Screenshot below is to illustrate what happens when the window is too small (cancel and save out of frame)

image

pkalita-lbl commented 6 months ago

It looks like Ionic doesn't support scrollable sheet modals out of the box. This issue looks like it might have some good workarounds though: https://github.com/ionic-team/ionic-framework/issues/24631

simroux commented 6 months ago

Interesting. Note that this may also be an artifact of the Android App currently displaying as part of a browser rather as a "real" app. The documentation from Ionic indicates that sheets "can be swiped or dragged up to become full-screen", but in my case it never becomes full-screen. So anyway, I wanted to document this now while I still remembered it, but we should probably only try to fix it once we have a "proper" Android App display.