search

microbiomedata / nmdc-metadata

Managing metadata and policy around metadata in NMDC
https://microbiomedata.github.io/nmdc-schema/
Other
2 stars 0 forks source link

Missing depth parameter on Brodie ER_DNA_379 #356

Open pvangay opened 3 years ago

pvangay commented 3 years ago

_Soil microbial communities from the East River watershed near Crested Butte, Colorado, United States - ER_DNA379 does not have a depth parameter on its sample page: https://data.microbiomedata.org/details/sample/igsn:IEWFS001F - but it's reported as 0-5 in his spreadsheet.

There may be other samples that also have this problem.

pvangay commented 3 years ago

Note that these values are represented as ranges in GOLD, therefore this is not a GOLD issue. This may be related to the need to support ranges from #355 - and perhaps disappears altogether on the portal sample page because the value may be represented as 0.

dehays commented 2 years ago

There are two parts to this - First, @turbomam did Bill's support for depth ranges ever get addeded to the schema? If not, there is a schema change (merge of a branch Bill worked on) and then subsequent support for ranges in the data portal search. Second, once the schema accepts ranges, properly set the range values in the biosample documents in Mongo. Could use a changesheet for that.

Assigning to Mark as he would be involved in the initial schema updates needed.