microbiomedata / nmdc-metadata

Managing metadata and policy around metadata in NMDC
https://microbiomedata.github.io/nmdc-schema/
Other
2 stars 0 forks source link

Implied but undocumented relationships with size_frac #391

Closed turbomam closed 1 year ago

turbomam commented 3 years ago

This is one component of #375

First, MIxS says size_frac not size_fract

Next, the NMDC Sample Metadata Template seems to imply that

Are sub-properties of the size_frac property. MIxS does not make those assertions.

The NMDC Sample Metadata Template also uses an undefined filter_size

It doesn't seem like the size_frac slot is ever used directly

mslarae13 commented 3 years ago

Note added to corret size_fract to frac

Definition for MIxS is "filtering pore size used in sample preparation" so it's more preparation metadata. I'm open to suggestions on what this should be. But, MIxS is more analyte preparation metadata & defines sample more as the analysis subsample than the biological sample itself. In my attempt to not diverge from MIxS, this is the field I felt best fit the information I was gathering.

turbomam commented 3 years ago

OK, I appreciate the effort to use MIxS terms. I may not really get the distinction you're making between MIxS's sample prep orientation and the orientation you're trying to emphasize.

I'm going to continue working through your recent posts and responses. I'll probably want a one-on-one live meeting soon.

mslarae13 commented 1 year ago

frac vs fract taken care of

sub property is irrelevant now.

IF size_frac is brought up again we can refer back.