microbiomedata / nmdc-ontology

Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

no relation graph #44

Closed turbomam closed 6 months ago

turbomam commented 6 months ago

Would supersede

representative diffs in nmdco-classes.json

diff nmdco-classes.json ../../nmdco-classes.json
       "id" : "http://purl.obolibrary.org/obo/ENVO_01001642",
-      "lbl" : "interglacial"
+      "lbl" : "interglacial",
+      "type" : "CLASS"
     }, {
       "id" : "http://purl.obolibrary.org/obo/ENVO_01001643",
       "lbl" : "ice age",
@@ -35442,10 +35444,6 @@
       "lbl" : "World Ocean"
     } ],
     "edges" : [ {
-      "sub" : "http://purl.obolibrary.org/obo/BFO_0000001",
-      "pred" : "is_a",
-      "obj" : "http://www.w3.org/2002/07/owl#Thing"
-    }, {
turbomam commented 6 months ago

nmdco-classes.owl can be reasoned with HermiT

turbomam commented 6 months ago
du nmdco-classes.json

2604 nmdco-classes.json

grep '"is_a"' nmdco-classes.json | wc -l

9836

grep '"CLASS"' nmdco-classes.json | wc -l

8188

turbomam commented 6 months ago

reverting back to main

du nmdco-classes.json

2640 nmdco-classes.json

grep '"is_a"' nmdco-classes.json | wc -l

10078

242 fewer in new branch, ~ 2% reduction

grep '"CLASS"' nmdco-classes.json | wc -l

8186

Decrease of 2 compared to new branch

turbomam commented 6 months ago

@turbomam do a robot diff!

see also

turbomam commented 6 months ago

@cmungall see

I filtered out AnnotationAssertion changes and made some annotations

I think nmdco is cleaner and more intuitive after the Elk 0.5.0 EnvO import and without the relation-graph merge