search

microbiomedata / nmdc-runtime

Runtime system for NMDC data management and orchestration
https://microbiomedata.github.io/nmdc-runtime/
Other
5 stars 3 forks source link

For NEON ingest code handle cases where platform is in instrument_model #279

Open aclum opened 1 year ago

aclum commented 1 year ago

relates to https://github.com/microbiomedata/nmdc-runtime/issues/249 For some of the records the ingest code populated instrument_name with Illumina Illumina HiSeq. This is because some of the NEON records have just platform and some have platform + model in field instrument_model. In those cases our ingest code should just use field instrument_model and not a concatenation of sequencingMethod and instrument_model. example record

        "id": "nmdc:omprc-11-h5e2px89",
        "instrument_name": "Illumina Illumina HiSeq",
        "name": "Terrestrial soil microbial communities - CPER_002-M-20130701-COMP-DNA1",
aclum commented 1 year ago

@sujaypatil96 FYI i updated the existing records manually w/changesheets in dev and prod today.

ssarrafan commented 1 year ago

@sujaypatil96 what's the status of this issue?
@aclum

ssarrafan commented 1 year ago

Doesn't appear to be active. Adding backlog label. @sujaypatil96 @aclum

aclum commented 1 year ago

It would be good to get this addressed before the surface water and benthic ingest