search

microbiomedata / nmdc-runtime

Runtime system for NMDC data management and orchestration
https://microbiomedata.github.io/nmdc-runtime/
Other
7 stars 3 forks source link

`client_id=None` in `/orcid_authorize` redirect URL #413

Closed PeopleMakeCulture closed 11 months ago

PeopleMakeCulture commented 11 months ago

Requests to https://api.microbiomedata.org/orcid_authorize should redirect to 

https://orcid.org/oauth/authorize?client_id={ORCID_CLIENT_ID}&response_type=token&scope=openid&redirect_uri={BASE_URL_EXTERNAL}/orcid_token

"BASE_URL_EXTERNAL" is evaluated as "https://api.microbiomedata.org/orcid_token" but "ORCID_CLIENT_ID" incorrectly resolves to None. The full redirect URL is:

https://orcid.org/oauth/authorize?client_id=None&response_type=token&scope=openid&redirect_uri=https:%2F%2Fapi.microbiomedata.org%2Forcid_token

"ORCID_CLIENT_ID" and "BASE_URL_EXTERNAL" should both be defined as env variables. I believe "ORCID_CLIENT_ID" needs to be updated to the new NMDC client_id.

NOTE: To reproduce, make sure to enter https://api.microbiomedata.org/orcid_authorize into your browser's url bar.

Image

PeopleMakeCulture commented 11 months ago

TODO: @PeopleMakeCulture to update ORCID_CLIENT_ID to NMDC_CLIENT_ID and deploy to Rancher

NOTE: Wait til after 12/7 due to SPIN planned outages: https://www.nersc.gov/live-status/motd/

dwinston commented 11 months ago

Done :tada: