Migrations: Address situations where migrator wants to report a problem

microbiomedata / nmdc-runtime

Runtime system for NMDC data management and orchestration

https://microbiomedata.github.io/nmdc-runtime/

Other

4 stars 3 forks source link

Migrations: Address situations where migrator wants to report a problem #474

Closed eecavanna closed 4 weeks ago

eecavanna commented 4 months ago

Currently, some migrators will call logger.error() to print a message (example). Will the error message be visible in the Jupyter notebook that "runs the migration"? Even if it is visible, is that sufficient (as opposed to, for example, raising an Exception)? These are things I will think about.

eecavanna commented 4 weeks ago

This is done. Migrators have been updated to raise Exceptions instead of only logging error messages (via this PR https://github.com/microbiomedata/berkeley-schema-fy24/pull/180). No changes are necessary in this repo.