microbiomedata / nmdc-runtime

Runtime system for NMDC data management and orchestration
https://microbiomedata.github.io/nmdc-runtime/
Other
4 stars 3 forks source link

Bump `nmdc-schema` from `10.0.0` to `10.1.0` #486

Closed aclum closed 4 months ago

aclum commented 4 months ago

Description

Upping nmdc-scheam from 10.0.0 to 10.1.0 to add new file type enums for binning.

eecavanna commented 4 months ago

TODO

aclum commented 4 months ago

@eecavanna doesn't the first item happen with the github actions? There are no migrations for 10.0.0 to 10.1.0 based on there not being a migration python script.

eecavanna commented 4 months ago

doesn't the first item happen with the github actions?

I'll check the code to refresh my memory, but I don't think GitHub Actions (currently) takes care of that. I think the GitHub Actions workflows were written under the assumption that the developer would have already done that. Here's what some (maybe obsolete) development documentation says:

https://github.com/microbiomedata/nmdc-runtime/blob/aca433990d2c25fdd83d40029b579e1227789d9a/docs/admin.md?plain=1#L97-L101

There are no migrations for 10.0.0 to 10.1.0 based on there not being a migration python script.

You're right, there is no migrator in the nmdc-schema repo defined for this version change. I was expecting there to be a "no op" migrator defined in nmdc-schema (as an explicit indicator that there is, indeed, no migration necessary). I'll check whether that's documented somewhere (I have forgotten).


Anyway, I'll run $ make update-deps on this branch locally, and then push up the changes that get generated, if there are any. I'll report back when done.

eecavanna commented 4 months ago

On my host machine, I ran the following command to attach to a bash shell running inside the fastapi container:

docker compose exec fastapi bash

In that container, I ran:

# make update-deps
pip install --upgrade pip-tools pip setuptools
Requirement already satisfied: pip-tools in /usr/local/lib/python3.10/site-packages (7.3.0)
Collecting pip-tools
  Downloading pip_tools-7.4.0-py3-none-any.whl.metadata (26 kB)
Requirement already satisfied: pip in /usr/local/lib/python3.10/site-packages (23.3.2)
Collecting pip
  Downloading pip-24.0-py3-none-any.whl.metadata (3.6 kB)
(...)

Next, I confirmed that the main.txt file contained this:

nmdc-schema==10.1.0
    # via -r requirements/main.in

Finally, I commited those changes to my local copy of this branch and pushed them up to GitHub so they would be included in this PR.

eecavanna commented 4 months ago

Hi @aclum, I'll merge this in now. As a result, the development environment will be updated "from schema version 10.0.0 to schema version 10.1.0."