microbiomedata / nmdc-runtime

Runtime system for NMDC data management and orchestration
https://microbiomedata.github.io/nmdc-runtime/
Other
4 stars 3 forks source link

Migrations: Fix invalid example notebook #492

Closed eecavanna closed 3 months ago

eecavanna commented 3 months ago

Description

In PR https://github.com/microbiomedata/nmdc-runtime/pull/487, I committed a Jupyter notebook that I didn't know was not formatted in a valid way.

In this PR, I am committing the same notebook in a valid way.

The invalid one was saved using PyCharm and the valid one was saved using VS Code. The PyCharm GUI has been buggy when it comes to Python notebooks, and—based on this issue—I think the under-the-hood piece of PyCharm that deals with Python notebook is buggy, too. I'm going to switch back to using VS Code for notebooks for now.

Fixes #490

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply make up-test && make test-run.

Configuration Details: none

Checklist:

eecavanna commented 3 months ago

I will merge this follow-up PR (also without review and without all the checkboxes in the PR description fill in) that fixes the issue.

Why no review? This impacts only a standalone Python notebook that doesn't affect the Runtime API. The reason the notebook is in the repo is that this repo holds the "keeper of the Mongo database," and the Python notebook is an example of something that would interact directly with the Mongo database. I don't want to request someone's time/attention for this.