search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

string vs enumeration for GOLD pathway slots #1108

Open aclum opened 1 year ago

aclum commented 1 year ago

I noticed that for GOLD pathway slots https://microbiomedata.github.io/submission-schema/gold_path_field/ the range is an enumeration in the submission portal and a string in nmdc-schema. Since most of the data will come in from ingest scripts which bypass the submission schema we should revisit making the validation consistent. Reddy has noted that they release new pathways as needed so we may have problems keeping in sync.

@turbomam @pkalita-lbl @mslarae13

mslarae13 commented 12 months ago

The enumeration on the submission portal is meant to help / guide people. However, I see it doesn't validate if you type in just any text. that one requires it comes from the enumeration. It probably should.

Curious on other peoples thoughts.

aclum commented 12 months ago

I think if populated both the submission schema and nmdc schema should use validate against the same enumeration and we need a process to keep this in sync with what GOLD has. Not sure how to do this w/o a release schedule from GOLD, perhaps we update quarterly.

mslarae13 commented 8 months ago

++ Can we prevent allowing people to type into this slot? Currently, you can type something into a lower level, but if you haven't selected anything in the 'upper' level of the hierarchy, it doesn't validate

See submission 6f99e199-c6c3-4d79-aac6-57446fde26f4

![Uploading Screenshot 2023-12-27 at 11.55.59 AM.png…]()