search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

attribute value should be abstract, doi should be something concrete #12

Closed dwinston closed 2 months ago

dwinston commented 3 years ago

Whereas named thing is abstract, attribute value is not abstract. However, doi is the only slot in the NMDC schema with a range of attribute value, rather than a range that is_a attribute value such as text value. I recommend that attribute value be made abstract: true and that the range of doi be made text value or another concretion of attribute value.

turbomam commented 11 months ago

doi will imminently be migrated to various ...dois

This is still a good issue to review

turbomam commented 10 months ago

Nothing is asserted to be an instance of AttributeValue, so I support the idea of making it abstract.

https://graphdb-dev.microbiomedata.org/resource?uri=https:%2F%2Fw3id.org%2Fnmdc%2FAttributeValue&role=object