Open turbomam opened 11 months ago
Use Case:
Refactor Biosample.
The Biosample Class is very overloaded, with:
Linked Issue:
Branch: https://github.com/microbiomedata/monterey-schema/tree/issue-1251-refactor-biosample
Monterrey Schema Diagram: https://app.diagrams.net/#G1Ufsblf98rGzRhJMDt7ZMgosioywnGJIU
Should we move this into the fork? & I haven't looked at it, but let's make sure the documentation of the fork is VERY clear that this is a model for what we plant to incrementally implement back into NMDC schema
another example of biosample being overloaded is img_identifiers, this is an analysis identifier, which should be associated w/MetagenomeAnnotationActivity, MetatranscriptomeAnnotationActivity, MagsAnalysisActivity. Currently Sujay populates these values so the ingest process would have to change
I would like to take a first pass at refactoring this before we meet in Dec. I was planning to do this as a branch off of the refactoring fork that Mark made. We can use the PR mechanism to review / modify the refactored model. There will also doubtless be any number of questions on terminology / semantics etc. to bring up to the team. #1251
Alicia's list
@aclum you're welcome to edit my initial comment in this thread, so that your checklist items will be eligible for click-to-create-issue.
Related to this standing issue: https://github.com/microbiomedata/nmdc-schema/issues/251
slot_usage
descriptions for all the has_input
and has_output
slots so that its clear what exactly is the input/output depending on the class using the slot.@lamccue Can you check out the issues and requests here & let me know which ones should be prioritized for the meeting? https://github.com/microbiomedata/nmdc-schema/issues/1466
range
constraints inslot_usage
salternative_id
s?