microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

what's the significance of saying that a (`Biosample`?) slot `is_a attribute` #1356

Closed turbomam closed 10 months ago

turbomam commented 11 months ago

https://microbiomedata.github.io/nmdc-schema/attribute/ only has 16 subproperties, out of the ~ 500 Biosample slots.

  1. zinc
  2. manganese
  3. ammonium_nitrogen
  4. nitrate_nitrogen
  5. nitrite_nitrogen
  6. lbc_thirty
  7. lbceq
  8. env_package
  9. gold_path_field
  10. principal_investigator
  11. execution_resource
  12. url
  13. display_order
  14. git_url
  15. file_size_bytes
  16. md5_checksum
turbomam commented 11 months ago
name: attribute
description: 'A attribute of a biosample. Examples: depth, habitat, material. For
  NMDC, attributes SHOULD be mapped to terms within a MIxS template'
from_schema: https://w3id.org/nmdc/nmdc
aliases:
- field
- property
- template field
- key
- characteristic
rank: 1000
abstract: true
alias: attribute
range: string
turbomam commented 11 months ago

So we shouldn't be asserting that a slot is_a attribute unless

bmeluch commented 11 months ago

Thank you Mark! And also, how binding is "attributes SHOULD be mapped to terms within a MIxS template"?

turbomam commented 11 months ago

Good question. I started a thread in the NMDC Slack metadata channel and tagged @cmungall. We should copy any conclusions from there back in this issue.

turbomam commented 11 months ago

In the absence of any feedback, I propose that we eliminate the attribute parent slot.