microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

clarify whether tests are expected to pass or fail #1414

Closed turbomam closed 3 months ago

turbomam commented 9 months ago

When in doubt, I'd like to delete these tests

Database-analytical_sample-extract-exhaustive.yaml

Database-analytical_sample-minimal.yaml

Study-genome_portal_identifiers.yaml

aclum commented 9 months ago

@turbomam What branch are you working in? I don't see these in the main branch. I didn't write ther first two yaml files but Study-genome_portal_identifiers.yaml I did write as a test for checking that slot jgi_portal_study_identifiers is working so that is expected to pass and I would like to keep it. It is possible that the recent changes to study modeling make this test fail but I'd assumed that would be addressed before a merge to main.

kheal commented 3 months ago

These examples no longer exist.