search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

remove vestiges of `Instrument` and `InstrumentValue` from schema #1443

Closed turbomam closed 2 months ago

turbomam commented 8 months ago

there was a comment on MetaproteomicsAnalysisActivity and NomAnalysisActivity _in src/schema/workflow_execution_activity.yaml_ that Instrument would be a good slot_usage range for used

cc @anastasiyaprymolenna 

Instrument:
  is_a: NamedThing
  aliases:
    - device
  description: >-
    A material entity that is designed to perform a function in a scientific investigation, but is not a reagent[OBI].
  exact_mappings:
    - OBI:0000485
  slot_usage:
    id:
      required: true
      structured_pattern:
        syntax: "{id_nmdc_prefix}:inst-{id_shoulder}-{id_blade}{id_version}{id_locus}"
        interpolated: true
kheal commented 2 months ago

Decision was made to keep the Instrument class, which is the range of the instrument_used slot; closing this issue. InstrumentValue has been removed on Berkeley fork.