microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

links in slot 'sample collection device' description are broken. #1480

Open mslarae13 opened 10 months ago

mslarae13 commented 10 months ago

The slot 'sample collection device' is a MIxS modified slot.

We should review how we modified it, and correct the broken links.

"Description: The device used to collect an environmental sample. This field accepts terms listed under environmental sampling device (http://purl.obolibrary.org/obo/ENVO). This field also accepts terms listed under specimen collection device (http://purl.obolibrary.org/obo/GENEPIO_0002094)."

turbomam commented 10 months ago

Thanks @mslarae13

The name of the slot you're talking about here is samp_collec_device. Thanks for providing the title.

@sujaypatil96 will be taking the lead on broken link diagnosis and repair. I have asked @eecavanna to help, and also for @dwinston to help on the off chance that broken links in the schema can be traced to our new link redirection based on w3id and the nmdc-runtime API.

In this case, the text you have provided matches the content of MIxS 6.1.1, so those broken links aren't due to a modification that any of us did.

The same description is present in MIxS 6.2.0, but the name of the slot has been changed to samp_collect_device. Chris H made that name change (along with a few similar ones) with the support of GSC.

So here are my suggestions: