search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Customize NMDC schema documentation pages to NOT show LinkML `todos` #1495

Open mslarae13 opened 6 months ago

mslarae13 commented 6 months ago

Showing todos in the NMDC schema documentation isn't ideal. These are things we should keep internal.

During a metabolink meeting we decided we needed to add todos, but have to put them in the notes so they don't appear in the docs.

Can we update the build of NMDC schema docs to NOT show todos?

mslarae13 commented 6 months ago

@sujaypatil96 when do you think you'd have time to work on this?

sujaypatil96 commented 3 months ago

@mslarae13 the NMDC schema documentation jinja templates have been customized/modified to not show todos anymore. I think this issue is good to be closed?

kheal commented 1 month ago

@sujaypatil96 I'm still seeing TODOs here: https://microbiomedata.github.io/nmdc-schema/ControlledTermValue/ and here: https://microbiomedata.github.io/berkeley-schema-fy24/ControlledTermValue/ .

sujaypatil96 commented 3 weeks ago

Thanks @kheal!! i'll make a PR to update this in berkeley-schema tomorrow.