microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

descriptions for induced slots are being dropped #174

Closed wdduncan closed 2 years ago

wdduncan commented 2 years ago

When you override a slot in the slot_usage specification for a class, the description in original slot is not translated into the jsonschema.

As an example: In the NMDC schema, we provide a definition for the env_broad_scale slot in the mixs.yaml schema.
We then require the env_broad_scale slot in the nmdc.yaml schema.
However, when we generate the NMDC jsonschema, the description is dropped.

This should now be fixed in linkml (see ticket 397). Related to nmdc-server ticket 505.

Need to test the linkml fix.

cmungall commented 2 years ago

Thanks for addressing this Bill

however, I suggest that schema introspection is done by inspecting the yaml (via the python library) rather than the json-schema. There are many things in the metamodel not supported by json-schema, including

wdduncan commented 2 years ago

@cmungall I agree using schema view would be better. Kitware uses the jsonschema. Perhaps we can get them to use schema view?