microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

update example data to napa -style identifiers #1868

Open aclum opened 5 months ago

aclum commented 5 months ago

After re-iding is complete and the materialized pattern version of the schema is enforced some of the example data will fail validation because there are legacy style identifiers. We can & should fix some of this in advance.

aclum commented 5 months ago

@turbomam took care of this several months ago.

aclum commented 3 months ago

This is fixed for IDs but not ID mentions.

aclum commented 3 months ago

@turbomam not quite sure what to do here. These are hard to find out with structured_pattern enforced for IDs and ID mentions. Some of this is fixed in Berkeley.

turbomam commented 3 months ago

Yeah, this is one of those things where the progress made in nmdc-schema and berkeley-schema-fy24 isn't totally clear

I'll

aclum commented 2 months ago

This PR addressed constraints on ID mentions which required updating all the example data to make it match. @bmeluch is separately going to review the invalid data to make sure tests fail or one and one one reason.

aclum commented 2 months ago

Assigning to @bmeluch so she can update the invalid example data. I fixed a lot of this in Berkeley but not in nmdc-schema.

bmeluch commented 1 month ago

Being addressed in Berkeley as part of https://github.com/microbiomedata/berkeley-schema-fy24/pull/220