search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

DataPortal can be searched for `Pathway`s and `OntologyGroup`s... does that justify leaving them in nmdc-schema? #1881

Closed turbomam closed 3 weeks ago

turbomam commented 5 months ago

Good question. Suggested by @mslarae13

mslarae13 commented 2 months ago

I don't remember making this suggestion :)

turbomam commented 2 months ago

whops! sorry @mslarae13

turbomam commented 2 months ago

@bmeluch you and discussed something like this earlier this week, right?

I recommend removing

There are no slots that have those classes as their asserted range, and those classes don't own any slots that appear in instances present in MongoDB.

bmeluch commented 2 months ago

Yes we talked about it since those classes do not appear anywhere in the example data. I guess we just have to make sure no one has been incubating any plans for them?

turbomam commented 2 months ago

I added this to the agenda for the upcoming NMDC Schema & Metadata meeting?

bmeluch commented 2 months ago

From 03 July Metadata/ Data Schema / Data Management Meeting: these classes were never used, we aren't modeling these at this level of granularity, put in a PR to remove them. Team will review and decide if it can be merged before or after Berkeley schema rollout.

See https://github.com/microbiomedata/berkeley-schema-fy24/tree/1881-deprecate-unused-classes

bmeluch commented 3 weeks ago

Closing this issue, this was addressed in Berkeley, see discussion in the linked PR

turbomam commented 2 weeks ago

@bmeluch is the URL for the linked PR in this issue somewhere?

I see this branch link, but that's closed now

bmeluch commented 2 weeks ago

It's not in a comment but in the "this was referenced" links in the issue history, https://github.com/microbiomedata/berkeley-schema-fy24/pull/222