search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

Refactor `principal_investigator` slot on `Study` #1917

Open brynnz22 opened 3 months ago

brynnz22 commented 3 months ago

Currently the principal_investigator slot is single valued, but some consortia have multiple principal investigators like WHONDRS and EMS. They have multiple people listed as a single value string (with a comma). Studies only have one investigator, but consortia might have multiple.

One way to fix this is to make the principal_investigator slot mulit-valued, but create a rule that says if research_category is a study, then the max_cardinality is 1.

This solution would require a migration.

kheal commented 2 months ago

Related to / duplicated with https://github.com/microbiomedata/nmdc-schema/issues/301 and https://github.com/microbiomedata/nmdc-schema/issues/458 and https://github.com/microbiomedata/nmdc-schema/issues/1437

turbomam commented 2 months ago

Good issue.

The design you're proposing here illustrates monotonic specialization of slots. There's some discussions about that here but no format documentation yet