search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

Add sets to `Database` for the `MaterialProcess` subclasses #1922

Closed anastasiyaprymolenna closed 3 months ago

anastasiyaprymolenna commented 3 months ago

Currently, no sets exist to be able to store the information that the MaterialProcess subclasses hope to capture. There will need to be sets written in for each subclass so the ids of the entries can be used by ProtocolExecution (which also needs a set) class to organize the individual sets into a sequence of processes.

turbomam commented 3 months ago

You're talking about https://microbiomedata.github.io/berkeley-schema-fy24/MaterialProcessing/ right?

turbomam commented 3 months ago

We should use an aggregative material_processing_set slot, not one slot for each subclass

turbomam commented 3 months ago

We already have it: https://microbiomedata.github.io/berkeley-schema-fy24/planned_process_set/

anastasiyaprymolenna commented 3 months ago

but that set is specifically for a PlannedProcess. Can we include each instance of the MaterialProcessing subtypes in that set?

anastasiyaprymolenna commented 3 months ago

I will close this issue based on Mark's comments, because we can put all the information we need about the MaterialProcessing subclasses on the planned_process_set