search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

Class Extraction issues #1957

Closed aclum closed 4 months ago

aclum commented 5 months ago

There are issues with the range of the following slots extraction_target extraction_method extraction_target is supposed to be the target molecule (ex DNA, protein) extraction_method is suppose to be by what process that target was extracted (ex phenol/chloroform extraction) The slots are currently using the same enum, ExtractionTargetEnum, which combines permissible values for the two concepts.

we should look at how this intersects with Berkeley schema but I'd like this fixed in nmdc-schema now if possible. @mslarae13

aclum commented 4 months ago

@kheal and I met this afternoon to discuss this. The commit that introduced these changes is https://github.com/microbiomedata/nmdc-schema/commit/accd3af7a3436ff94943a3c286615f0b1856fc75

The plan is to revert ExtractionTargetEnum to what it was before this commit and to make no changes to extraction_method range at this time as that is modeled differently in berkeley schema with protocol_link.

cc @turbomam @kheal @anastasiyaprymolenna