Remove phenol/chloroform extraction from `ExtractionTargetEnum`

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model

https://microbiomedata.github.io/nmdc-schema/

Creative Commons Zero v1.0 Universal

27 stars 8 forks source link

Remove phenol/chloroform extraction from `ExtractionTargetEnum` #1965

Closed aclum closed 4 months ago

aclum commented 4 months ago

This PR addresses issues introduced by commit accd3af which conflated permissible values for two concepts, specifying the target molecule for extraction_target and the lab method by which target molecule was extracted, into single enumeration, ExtractionTargetEnum.

kheal commented 4 months ago

Looks good, thanks @aclum for fixing this. It will help avoid merge conflicts down the road.

turbomam commented 4 months ago

Sorry, @kheal I should have waited for your review before merging

kheal commented 4 months ago

No problem, looks fine to me.