microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

`berkeley-schema-fy24`: Finalize names of Berkeley schema migrators #1983

Closed eecavanna closed 1 week ago

eecavanna commented 1 month ago

Tasks

Background

Currently, Berkeley schema migrators have names like migrator_from_X_to_PR9 because (a) we didn't know what order they'd be run in and (b) we didn't know what the starting and ending schema versions would be.

CC: @brynnz22 and @turbomam

ssarrafan commented 1 month ago

@eecavanna I know you were working on this. Should it be moved to the next sprint or do you think it'll be done today?

eecavanna commented 1 month ago

Hi @ssarrafan, I think it will be done today.

eecavanna commented 1 month ago

I will move this to the next sprint after all. I expect to have implemented it in a PR today, but I don't think that PR will be merged into berkeley-schema-fy24/main today (one of the people I will want to review it is out today).

eecavanna commented 1 week ago

I implemented this in https://github.com/microbiomedata/berkeley-schema-fy24/pull/218 (awaiting review/merge). The merging of that PR might be dependent upon approval from the Berkeley schema roll out squad members, since we're in a "schema freeze" period and the migrators happen to live in the same repo as the schema.

ssarrafan commented 1 week ago

@eecavanna so should this be in the backlog for now?

eecavanna commented 1 week ago

I'd prefer it be in the next sprint, in the column that indicates it's being reviewed.

I do expect it to be merged in even though we're in this freeze period. The squad members just introduced this additional administrative step in an attempt to prevent accidentally breaking things downstream from the schema.