microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Remove `acquisition_category` slot and `AcquisitionCategoryEnum` #2018

Closed kheal closed 1 month ago

kheal commented 1 month ago

@corilo, @SamuelPurvine et al agreed to collapse these slots for simplicity and to better match mappings as uncovered during work for https://github.com/microbiomedata/issues/issues/705

Remove acquisition_category slot and AcquisitionCategoryEnum. Add "full-scan only" as a permissible value to AcquisitionStrategyEnum. Rename EnumAcquisitionStrategyEnum to MassSpectrometryAcquisitionStrategyEnum Rename slot acquisition_strategy to mass_spectrometry_acquisition_strategy

mslarae13 commented 1 month ago

& update mass_spectrometryacquisition_strategy description from

description: whether spectra are dependent on or independent of any other spectra during the experiment

to

   description: Mode of running a mass spectrometer method by which m/z ranges are selected and ions possibly fragmented
mslarae13 commented 1 month ago

See commit https://github.com/microbiomedata/berkeley-schema-fy24/pull/179/commits/11ade68be0d35fe4a730b77ec56aec3ff0803dac

in https://github.com/microbiomedata/berkeley-schema-fy24/pull/179

mslarae13 commented 1 month ago

acquisition_strategy to mass_spectrometry_acquisition_strategy causes issues. Will follow up with commit link where this is corrected.