search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Restore adapter method lost during PR #2009 merge: `do_for_each_document` #2032

Closed eecavanna closed 1 month ago

eecavanna commented 1 month ago

While merging PR https://github.com/microbiomedata/nmdc-schema/pull/2009, the adapter method that had been merged in via PR https://github.com/microbiomedata/nmdc-schema/pull/2006 was accidentally deleted. Details are in Issue https://github.com/microbiomedata/nmdc-schema/issues/2031.

In this branch, I have restored the deleted method and other deleted code related to the deleted method. All of this code was once in the main branch—specifically, from the time https://github.com/microbiomedata/nmdc-schema/pull/2006 was merged into main and the time https://github.com/microbiomedata/nmdc-schema/pull/2009 was merged into main.

I want this branch to be merged into main already despite a "schema freeze" being in effect.

Rationale:

  1. This isn't a change to the schema
  2. I think all migration squad members were under the impression both of these methods existed in main (I had been planning to make use of both of them in the berkeley-schema-fy24 repo once the merge of nmdc-schema/main into berkeley-schema-fy24 had taken place; in order to speed up the Berkeley schema-related migrations)
eecavanna commented 1 month ago

I am ready for this PR branch to be merged in. All of the code being added in this branch was reviewed as part of PR #2006.

turbomam commented 1 month ago

I am making the executive decision to merge this PR now, because

  1. It does not effect the schema in any way
  2. Multiple people had reviewed it for inclusion before the freeze. It's absence is just a technical failing of my manual merge process.
turbomam commented 1 month ago

If or when we do another merge between nmdc-schema and berkeley-schema-fy24, in either direction, I would like to partner with a highly skilled git person. I have lost some of my non-schema files before too.