microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

backmerge issue with ID mention pattern constraints on WorkflowExecution #2053

Closed aclum closed 3 weeks ago

aclum commented 3 weeks ago

I discovered today that there is some example data in Database-interleaved.yaml where the has_input/has_output values are accepting md5sum style identifiers. When I check https://microbiomedata.github.io/berkeley-schema-fy24/WorkflowExecution/ there are not slot usage constaints for has_input, has_output, or was_informed_by. The same is not true for PlannedProcess subclasses so not sure what happened but we should review ID mentions in general in berkeley-schema-fy24 to make sure other Classes were merged correctly.

turbomam commented 3 weeks ago

Can WorkflowExecutions be informed_by?

turbomam commented 3 weeks ago

I'm not going to finish this today

aclum commented 3 weeks ago

No, we moved was_informed_by from WorkflowExecution to WorkflowChain.