search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Add migrator for `nom_analysis_activity` ID #2059

Closed JamesTessmer closed 2 weeks ago

JamesTessmer commented 3 weeks ago

This migrator will be used to append version numbers to IDs that currently have none.

Add to resolve Issue https://github.com/microbiomedata/nmdc-schema/issues/2010

JamesTessmer commented 3 weeks ago

Hi @JamesTessmer, thanks for implementing this. I left some feedback comments.

Thanks for all the feedback @eecavanna ! I'll get this all done today.

JamesTessmer commented 3 weeks ago

@eecavanna I've updated everything with the examples you showed and your suggestions. I'm marking this as ready for review

Edit: Oops I had never marked it as a draft to begin with

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2059/ on branch gh-pages at 2024-06-14 18:33 UTC

eecavanna commented 2 weeks ago

I will update this branch to reference different schema version numbers. New commit(s) coming soon.

eecavanna commented 2 weeks ago

@JamesTessmer, do you know the version number of the schema release in which the schema changes associated with this migrator were introduced? Alternatively, do you know which PR those schema changes were introduced into the repo in? I'm trying to determine what the correct "to" and "from" versions are for this migrator. I assumed the 10.3.0 and 10.4.0 (which I have since replaced) were placeholders.

CC: @turbomam

JamesTessmer commented 2 weeks ago

@eecavanna I have no idea where the changes for these come from. In the issue (https://github.com/microbiomedata/nmdc-schema/issues/2010) this PR is for @aclum said the 'from' version was 10.3.0

eecavanna commented 2 weeks ago

OK, thanks, @JamesTessmer. I'll work with @aclum and @turbomam tomorrow to identify the version numbers, then I'll put them into this branch.

eecavanna commented 2 weeks ago

I'll merge this in once the GHA checks pass.