search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Remove `activity_set` slot from `Database` class #2082

Closed aclum closed 1 week ago

aclum commented 1 week ago

PR to remove references to WorkflowExecutionActivity in Class Database

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2082/ on branch gh-pages at 2024-06-20 20:42 UTC

eecavanna commented 1 week ago

One of the GitHub Actions workflows failed, showing this error message:

packages/linkml/workspaces/example_runner.py", line 193, in process_examples_from_list
    raise ValueError(f"Example {input_example} failed validation:\n{e}")
ValueError: Example src/data/valid/Database-img_mg_annotation_objects.yaml failed validation:
Error:  Additional properties are not allowed ('activity_set' was unexpected) in /
make: *** [project.Makefile:103: examples/output] Error 1
Error: Process completed with exit code 2.

Here's a link to the failing example file (i.e. src/data/valid/Database-img_mg_annotation_objects.yaml):

https://github.com/microbiomedata/nmdc-schema/blob/f8dbeb69fccc2d76066c598d6e4a948925b55197/src/data/valid/Database-img_mg_annotation_objects.yaml#L1

eecavanna commented 1 week ago

I will add a "no op" migrator to this PR for documentation purposes (to document the fact that this schema change does not require migration).

eecavanna commented 1 week ago

I'm comfortable with this being merged in.