microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Update migrator to keep `DataObject.was_generated_by` in sync with updated `id` #2088

Closed eecavanna closed 1 week ago

eecavanna commented 1 week ago

In this branch, I updated an existing migrator so that, whenever it updates the id of a document in the nom_analysis_activity_set collection, it also updates the associated data_object_set's was_generated_by field to use that new id. Previously, this migrator did not do the latter.

Reviewers can refer to the doctests in each function's docstring, for example(s) of how that function behaves.

Requesting reviews from:

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2088/ on branch gh-pages at 2024-06-25 21:33 UTC

eecavanna commented 1 week ago

Thanks for reviewing this. I'll go ahead and merge it in now, given that we are cutting it pretty close to tomorrow's release.