Open turbomam opened 1 week ago
PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2098/
on branch gh-pages
at 2024-07-01 21:53 UTC
Hi @turbomam, will you add a description to this PR?
Here's a skeleton:
{high-level description of changes: the what and the why}
.I think that'll make it easier for all the reviewers to review the changes.
I got some additional context by reading the attached GitHub Issue: https://github.com/microbiomedata/nmdc-schema/issues/2092
I'm approving this PR based on the assumption that the changes in this PR fix that issue.
@eecavanna
will you add a description to this PR
Done.
@turbomam can this be closed by tomorrow?
Regular expression patterns can be left anchored with
^
and/or right anchored with$
. Anything that comes before or after one of those anchors invalidates otherwise acceptable strings.LinkML validates strings with the
pattern
metaslot onSlotDefinitions
. Because some patterns are a pain to write, LinkML also offersstructured_pattern
s which can be composed from LinkMLsettings
. At this point in time,structured_pattern
s can be converted intopattern
s with thegen-linkml
command in--materialize-patterns
mode.Thew LinkML language doesn't take any stance on whether anchors should go inside of
settings
as below, or whether they should go in thestructured_pattern.syntax
This PR does take a stand: anchors should go in
settings
, not instructured_pattern.syntax
, and it fixes existingstructured_pattern.syntax
to follow that rule.