search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
26 stars 8 forks source link

Remove `nmdc_schema/nmdc_schema_merged.yaml` along with all references to it #2099

Open turbomam opened 1 week ago

turbomam commented 1 week ago

see

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2099/ on branch gh-pages at 2024-07-01 22:52 UTC

eecavanna commented 1 week ago

Update: I made this comment based upon a misunderstanding I had about this branch.

I recommend removing this doctest (two lines of a docstring), since the two schemas being compared are the same.

    >>> len(bytes_b) > len(bytes_a)  # assumes that including structured patterns makes the file larger
    True

On a side note, I'm surprised this doctest didn't fail here in the PR, when GHA ran the tests.

eecavanna commented 1 week ago

I like this PR title.

eecavanna commented 1 week ago

I met briefly with @turbomam and it turned out I had been mistakenly thinking of an unrelated conversation when I was reviewing this PR. That led to me requesting (above) that he remove a doctest. As he and I discussed, I will make a commit on this branch that restores that doctest.

turbomam commented 2 days ago

That said I did have a question on the issue for my own clarification.

Thanks. Did this answer your questions?

ssarrafan commented 16 hours ago

That said I did have a question on the issue for my own clarification.

Thanks. Did this answer your questions?

@mslarae13 I'm assuming your question was answered in the source issue correct? Can we close this? It looks like it was reviewed by Alicia and Eric too.