search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

GHA uses Python 3.9 for building docs, but Python 3.10 for building package #2191

Open eecavanna opened 1 day ago

eecavanna commented 1 day ago

Python 3.9

https://github.com/microbiomedata/nmdc-schema/blob/5930933d2115664ddcd94776f0d07201bb409960/.github/workflows/deploy-docs.yaml#L15-L18

https://github.com/microbiomedata/nmdc-schema/blob/5930933d2115664ddcd94776f0d07201bb409960/.github/workflows/test_pages_build.yaml#L21-L24

Python 3.10

https://github.com/microbiomedata/nmdc-schema/blob/5930933d2115664ddcd94776f0d07201bb409960/.github/workflows/pypi-publish.yaml#L19-L22

Commentary

I assume this was not intentional. I recommend using Python 3.10 for all three; or documenting why the docs-related ones are still using Python 3.9.

eecavanna commented 1 day ago

They each use a distinct version of the actions/setup-python action, too.

turbomam commented 1 day ago

Nice catch @eecavanna