search

microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

make slot usage range match structured syntax patterns #2238

Open aclum opened 2 weeks ago

aclum commented 2 weeks ago

The current range constraints where the range is a class are frequently looser than the constraints on identifier mentions via structured syntax patterns. This is causing confusion as people read the linkml documentation without looking at the linkml source and makes the inter-class diagrams refscan is making impractical to use.

Example: Range for has_input on WorkflowExecution has a range of NamedThing, this can be tightened to DataObject which what is specified in the structured_pattern syntax

'{id_nmdc_prefix}:(dobj)-{id_shoulder}-{id_blade}$'

Please go through the ranges in the schema to make sure the level of granularity is the same, making grouping classes as appropriate.

ssarrafan commented 1 day ago

@sierra-moxon @turbomam any update on this one? I see no updates or comments for 2 weeks so I will remove from the sprint and add the backlog label unless you're working on it?

FYI @aclum @eecavanna

sierra-moxon commented 1 day ago

I am just seeing this; apologies. I will take it on, but I have not started it during this sprint - it should go to the next.