microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

`data_object_type ` values of "Metagenome Raw Reads" in mongodb #487

Closed turbomam closed 11 months ago

turbomam commented 2 years ago

there are data_object_type values of "Metagenome Raw Reads" in mongodb, but that is not yet a permissible value in file type enum

turbomam commented 2 years ago

I am going to add that permissible value and merge it in. @scanon please either add some metadata/annotations to the new permissible value, or delegate that to someone else who has the subject matter knowledge

turbomam commented 2 years ago

in src/schema/nmdc.yaml

  file type enum:
    permissible_values:
      Metagenome Raw Reads:
        todos: add annotations
aclum commented 11 months ago

@mbthornton-lbl please add slot description to FileTypeEnum value "Metagenome Raw Reads"

mbthornton-lbl commented 11 months ago

PR is here: https://github.com/microbiomedata/nmdc-schema/pull/1266