microbiomedata / nmdc-schema

National Microbiome Data Collaborative (NMDC) unified data model
https://microbiomedata.github.io/nmdc-schema/
Creative Commons Zero v1.0 Universal
27 stars 8 forks source link

Biosamples metadata requirements derived from a pooling process #910

Closed aclum closed 1 year ago

aclum commented 1 year ago

Based on discussions yesterday there is a use case where we might want to require fewer fields from a bioscale that is derived from another biosample. Examples include NEON where 3 biosamples from the same plot are combined or when different soil core depths are combined. While it is feasible to do in the nmdc schema with linkml if statements this has complicating factors for other systems.

Pro: this more accurately models what happens in the field, some values aren't going to be accurate, environmental MIxS terms could get out of sync b/w parent and children records, etc. Con: more complicated

Tasks

Other tasks depending discussion.

@pkalita-lbl @cmungall @jeffbaumes @naglepuff @shreddd @mslarae13

turbomam commented 1 year ago

Good issue.

Another approach we have discussed is using relatively generic classes as the inputs and outputs to most processes. If the domains and ranges are set to MaterialEntity, than that will support using Biosample and the new ProcessedSample, which can have a minimal number of required slots.

aclum commented 1 year ago

To be discussed at the Wed sync meeting.

aclum commented 1 year ago

For NEON we will model outputs of pooling as Class ProcessedSample. cc @jeffbaumes @naglepuff