search

microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
9 stars 0 forks source link

`POSTGRES_URI` environment variable may be redundant #1018

Open eecavanna opened 1 year ago

eecavanna commented 1 year ago

There are two environment variables that, in the new development environment, are being populated from the same source (which is the POSTGRES_URI key of the postgres secret).

image

I think these two environment variables could be consolidated into a single one, as long as the usages of the removed one are updated. I think consolidating them would simplify deployment of the application.

I searched for both environment variable names using GitHub's code search, and found that they occur in the following places:

Environment variable name: NMDC_DATABASE_URI (search results: https://github.com/search?q=repo%3Amicrobiomedata%2Fnmdc-server%20NMDC_DATABASE_URI&type=code)

Environment variable name: POSTGRES_URI (search results: https://github.com/search?q=repo%3Amicrobiomedata%2Fnmdc-server+POSTGRES_URI&type=code)

ssarrafan commented 1 year ago

@eecavanna let me know if this should be added to the next sprint. Thank you for adding the size label.

eecavanna commented 1 year ago

Hi @ssarrafan, I don't think so. I created it to document a possible oversight. If it is, indeed, an oversight, I think I'd file it under "code cleanup" (as opposed to, for example, "bug"). It isn't causing any problems for me and is a low priority to me. Putting it into a product backlog (as opposed to next sprint's sprint backlog) would make sense to me.